Skip to content

No reason to add kwargs to object in Gitlab.list()-method #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpocentek merged 1 commit into from
Oct 11, 2014
Merged

No reason to add kwargs to object in Gitlab.list()-method #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,14 @@ def list(self, obj_class, **kwargs):
cls = obj_class
if obj_class._returnClass:
cls = obj_class._returnClass
l = [cls(self, item) for item in r.json() if item is not None]
if kwargs:
for k, v in kwargs.items():
if k in ('page', 'per_page'):
continue
for obj in l:
obj.__dict__[k] = str(v)
return l

# Remove parameters from kwargs before passing it to constructor
cls_kwargs = kwargs.copy()
for key in ['page', 'per_page']:
if key in cls_kwargs:
del cls_kwargs[key]

return [cls(self, item, **cls_kwargs) for item in r.json() if item is not None]
elif r.status_code == 401:
raise GitlabAuthenticationError(r.json()['message'])
else:
Expand Down