Merged
Conversation
Contributor
Author
|
Happy to squash the linter issues & fixes. |
Contributor
|
@nathschmidt Thank you for this patch! It looks good but I'm not sure how I can test it, I don't really have experience with oauth. I'm wondering if I can test on gitlab.com with auth from github. Any feedback on this? |
Contributor
Author
|
Hmmm, I'm not sure if you can chain the OAuth that way - worth a try. I've tested it against an in house gitlab-ee (v0.10) - with great success. |
Contributor
|
OK, let's merge. It won't break the current private_token support, that's good enough for now. Thank you for resurrecting the topic @nathschmidt :) |
Contributor
Author
|
This is great, thanks! When do you think the next release will be? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #163
Small change that adds support for Oauth tokens. Follows the same flow as the standard private token - instead of setting the
PRIVATE-TOKENheader setsAuthorization. Deprecated methods have not been updated/changed. Existing open PR's for this issue haven't been used as they're over a year old and the codebase seems to have changed rather dramatically.There's possibly a slight issue with providing both
private_tokenandoath_token, asprivate_tokenwill silently take precedence maybe a warning or error would be clearer. I think the chance of a user actually doing that is pretty slim though.I've verified against a v0.10 gitlab (v4 API). Shouldn't be any break to the existing interface.
Let me know if you've got any questions.