Skip to content

Fix trigger variables in v4 API #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpocentek merged 2 commits into from
Oct 8, 2017
Merged

Fix trigger variables in v4 API #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d609a
Fix trigger variables in v4 API
jeromerobert Oct 3, 2017
7cdc301
Remove six import (pep8)
Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions gitlab/v4/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
from __future__ import absolute_import
import base64

import six

from gitlab.base import * # noqa
from gitlab import cli
from gitlab.exceptions import * # noqa
Expand Down Expand Up @@ -2080,9 +2078,7 @@ def trigger_pipeline(self, ref, token, variables={}, **kwargs):
GitlabCreateError: If the server failed to perform the request
"""
path = '/projects/%s/trigger/pipeline' % self.get_id()
form = {r'variables[%s]' % k: v for k, v in six.iteritems(variables)}
post_data = {'ref': ref, 'token': token}
post_data.update(form)
post_data = {'ref': ref, 'token': token, 'variables': variables}
self.manager.gitlab.http_post(path, post_data=post_data, **kwargs)

# see #56 - add file attachment features
Expand Down