fix(epics): use actual group_id for save/delete operations on nested epics #3279
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where save() and delete() operations on epics retrieved through a parent group's epic listing would fail because they used the wrong group path. The fix ensures that operations use the epic's actual group_id attribute to construct the correct API path.
- Overrides save() and delete() methods in GroupEpic to use the epic's group_id for API path construction
- Adds helper method
_epic_path()to compute the correct API path using the epic's real group - Adds comprehensive test coverage for both unit and functional scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gitlab/v4/objects/epics.py | Implements the fix by overriding save() and delete() methods to use epic's group_id for path construction |
| tests/unit/objects/test_epics.py | Adds unit tests to verify save() and delete() operations use the correct group path |
| tests/functional/api/test_epics.py | Adds functional test demonstrating the fix works for nested epics accessed through parent groups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
0f7065d to
3e75d60
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
3e75d60 to
3993fe7
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
2 times, most recently
from
3e855f3 to
27bd80c
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
27bd80c to
dcc9847
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3279 +/- ##
==========================================
+ Coverage 95.72% 95.73% +0.01%
==========================================
Files 98 98
Lines 6052 6068 +16
==========================================
+ Hits 5793 5809 +16
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
dcc9847 to
f420862
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
f420862 to
a9638ee
Compare
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
a9638ee to
fb4f902
Compare
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
fb4f902 to
8397bd0
Compare
|
FYI: This was tested and reported as working #3261 (comment) |
…epics When an epic belonging to a subgroup is retrieved through a parent group's epic listing, save() and delete() operations would fail because they used the parent group's path instead of the epic's actual group_id. This commit overrides save() and delete() methods in GroupEpic to use the epic's group_id attribute to construct the correct API path, ensuring operations work correctly regardless of how the epic was retrieved. Also add the ability to pass a custom path using `_pg_custom_path` to the `UpdateMixin.update()` and `SaveMixin.save()` methods. This allowed the override of the `update()` method to re-use the `SaveMixin.save()` method. Closes: #3261
JohnVillalovos
force-pushed
the
jlvillal/3261_epic_group
branch
from
8397bd0 to
45a8599
Compare
When an epic belonging to a subgroup is retrieved through a parent
group's epic listing, save() and delete() operations would fail because
they used the parent group's path instead of the epic's actual group_id.
This commit overrides save() and delete() methods in GroupEpic to use
the epic's group_id attribute to construct the correct API path, ensuring
operations work correctly regardless of how the epic was retrieved.
Also add the ability to pass a custom path using
_pg_custom_pathtothe
UpdateMixin.update()andSaveMixin.save()methods. This allowedthe override of the
update()method to re-use theSaveMixin.save()method.
Closes: #3261