Skip to content

Conversation

@nejch
Copy link
Member

@nejch nejch commented Sep 30, 2024

Closes #2998

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (64eed5d) to head (f63ab6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3002   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          95       95           
  Lines        6087     6088    +1     
=======================================
+ Hits         5881     5882    +1     
  Misses        206      206           
Flag Coverage Δ
api_func_v4 82.58% <100.00%> (+0.11%) ⬆️
cli_func_v4 82.90% <100.00%> (+<0.01%) ⬆️
unit 88.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/files.py 100.00% <100.00%> (ø)

@max-wittig max-wittig merged commit 190ec89 into main Sep 30, 2024
@max-wittig max-wittig deleted the fix/file-get-error branch September 30, 2024 12:53
@max-wittig
Copy link
Member

@nejch Should we add a test for this somehow?

@nejch
Copy link
Member Author

nejch commented Sep 30, 2024

@max-wittig I was also thinking about it initially, but not sure how we could do it explicitly while also covering other potential overrides. A simple test would only be for this specific case without adding more magic to collect all overrides.

Otherwise we'd have to go more in the direction of tests in https://github.com/python-gitlab/python-gitlab/tree/main/tests/unit/meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitlabHttpError raised instead of GitlabGetError

3 participants