Skip to content

feat(api): project/group hook test triggering#2950

Merged
JohnVillalovos merged 1 commit intopython-gitlab:mainfrom
JacobHenner:feat-add-hook-tests
Aug 9, 2024
Merged

feat(api): project/group hook test triggering#2950
JohnVillalovos merged 1 commit intopython-gitlab:mainfrom
JacobHenner:feat-add-hook-tests

Conversation

@JacobHenner
Copy link
Copy Markdown
Contributor

Add the ability to trigger tests of project and group hooks.

Fixes #2924

Changes

  • Add the ability to trigger tests of project and group hooks

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.53%. Comparing base (8d74b88) to head (f099108).

Files Patch % Lines
gitlab/v4/objects/hooks.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
+ Coverage   88.52%   96.53%   +8.00%     
==========================================
  Files          94       94              
  Lines        5986     5997      +11     
==========================================
+ Hits         5299     5789     +490     
+ Misses        687      208     -479     
Flag Coverage Δ
api_func_v4 82.60% <63.63%> (?)
cli_func_v4 83.47% <63.63%> (?)
unit 88.52% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/exceptions.py 100.00% <100.00%> (ø)
gitlab/v4/objects/hooks.py 95.34% <77.77%> (-4.66%) ⬇️

... and 46 files with indirect coverage changes

Add the ability to trigger tests of project and group hooks.

Fixes python-gitlab#2924
@JacobHenner JacobHenner force-pushed the feat-add-hook-tests branch from f099108 to 1f2da4a Compare August 9, 2024 17:31
Copy link
Copy Markdown
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@JohnVillalovos JohnVillalovos merged commit 9353f54 into python-gitlab:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for testing/triggering Project and Group hooks

2 participants