Support SSL verification via internal CA bundle#294
Merged
gpocentek merged 1 commit intopython-gitlab:masterfrom Aug 5, 2017
Merged
Conversation
mdhausman
commented
Jul 31, 2017
mdhausman
commented
- Also updates documentation
- See issues Specify CA certificate #204 and Gitlab.from_config doesn't allow string ssl_verify #270
Author
|
Hm. I don't think my code changes touch anything that's broken in these checks, but these checks are definitely broken somehow. |
mdhausman
force-pushed
the
feature_internal_cert_configuration
branch
2 times, most recently
from
a48dcbe to
e7fe2a8
Compare
Contributor
|
The python3.6 failure is definitely not related to your patch. The functional tests failure is probably a temporary error. Let's see how it goes with a new run. |
Contributor
|
The patch looks good BTW, thanks! |
Author
|
Glad it looks good. Wish the tests were working, though 😅 |
mdhausman
force-pushed
the
feature_internal_cert_configuration
branch
2 times, most recently
from
0789098 to
8f6ef0e
Compare
Contributor
|
Could you rebase your change on the current master? The tests should be OK now. |
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
force-pushed
the
feature_internal_cert_configuration
branch
from
8f6ef0e to
4af4748
Compare
Author
|
Success! 💃 🎉 🎊 🍾 |
Contributor
|
Thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.