Fixed repository_compare examples#282
Merged
gpocentek merged 2 commits intopython-gitlab:masterfrom Jul 10, 2017
Merged
Conversation
gpocentek
suggested changes
Jul 9, 2017
Contributor
gpocentek
left a comment
gpocentek
left a comment
There was a problem hiding this comment.
Nice catch, thank you!
Could you fix the 2 problems?
docs/gl_objects/projects.py
Outdated
| # get the commits | ||
| for i in commit: | ||
| print(result.commits) | ||
| for commit in result.commits: |
Contributor
There was a problem hiding this comment.
result is a dict, so you need result['commits'] here.
docs/gl_objects/projects.py
Outdated
|
|
||
| # get the diffs | ||
| for file_diff in commit.diffs: | ||
| for file_diff in result.diffs: |
Author
|
You are right, I fixed them. |
Contributor
|
Looks good, thank you for the quick update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.