Docs 📖: Add link to gitlab docs on obtaining a token#278
Merged
gpocentek merged 1 commit intopython-gitlab:masterfrom Aug 4, 2017
Merged
Docs 📖: Add link to gitlab docs on obtaining a token#278gpocentek merged 1 commit intopython-gitlab:masterfrom
gpocentek merged 1 commit intopython-gitlab:masterfrom
Conversation
asfaltboy
changed the title
gpocentek
suggested changes
Jul 9, 2017
Contributor
gpocentek
left a comment
gpocentek
left a comment
There was a problem hiding this comment.
Very good idea, thank you. Can you update the sentence with my suggestions?
Thanks!
docs/cli.rst
Outdated
| - URL for the GitLab server | ||
| * - ``private_token`` | ||
| - Your user token. Login/password is not supported. | ||
| Please refer `the official documentation`__ to learn how to obtain a token. |
Contributor
There was a problem hiding this comment.
You can remove Please here as you're not asking for permission to the reader ;)
I'm not a native english speaker but I believe "Refer to the official doc..." is better.
I find these sort of links very user friendly 😅
asfaltboy
force-pushed
the
link-docs-gitlab-token
branch
from
5763741 to
9b8b806
Compare
Contributor
Author
|
Thanks @gpocentek , removed "Please" and amended the commit. |
Contributor
|
Thanks! The test failures are not related to this patch so let's merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find these sort of links very user friendly 😅