fix: Fix 404 not found error for saving approval rules #2637
Closed
robinson96 wants to merge 1 commit intopython-gitlab:mainfrom
Closed
fix: Fix 404 not found error for saving approval rules #2637robinson96 wants to merge 1 commit intopython-gitlab:mainfrom
robinson96 wants to merge 1 commit intopython-gitlab:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2637 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 90 90
Lines 5866 5867 +1
=======================================
+ Hits 5660 5661 +1
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
bugfix/approval_rules_id_fix
branch
2 times, most recently
from
aee8dae to
230a62a
Compare
JohnVillalovos
force-pushed
the
bugfix/approval_rules_id_fix
branch
from
5ca8eb4 to
e6fb635
Compare
Member
|
I'm going to close this as I think it has already been fixed in #2773 . And the latest published version of python-gitlab has the fix. If you disagree please re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save() was getting id of the merge request instead of id of the approval_rule, setting _id_attr to approval_rule_id addresses this issue.