Add support for nested groups#257
Merged
gpocentek merged 2 commits intopython-gitlab:masterfrom May 20, 2017
matejzero:patch-1
Merged
Add support for nested groups#257gpocentek merged 2 commits intopython-gitlab:masterfrom matejzero:patch-1
gpocentek merged 2 commits intopython-gitlab:masterfrom
matejzero:patch-1
Conversation
- added test for 'parent_id'
Contributor
Author
|
I've added all group attributes found on GitLab API page. Tests currently only for |
Contributor
|
Thank you for this change, I actually needed it myself 👍 I took the liberty to fix the minor problem which made the tests fail. |
Contributor
Author
|
Thanks for merging. I wanted to fix the failing tests, but was busy with gitlab migration for the last 2 weeks, so thanks for fixing that as well:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
parent_idattribute support when creating groups, so we can create nested groups.I'm not sure if this is the only change needed, but it is working on my local copy and I have successfully created nested groups while migrating SVN to GitLab.