Skip to content

Conversation

@matejzero
Copy link
Contributor

@matejzero matejzero commented May 10, 2017

Add parent_id attribute support when creating groups, so we can create nested groups.

I'm not sure if this is the only change needed, but it is working on my local copy and I have successfully created nested groups while migrating SVN to GitLab.

- added test for 'parent_id'
@matejzero
Copy link
Contributor Author

I've added all group attributes found on GitLab API page.

Tests currently only for parent_id.

@gpocentek gpocentek merged commit 5afeeb7 into python-gitlab:master May 20, 2017
@gpocentek
Copy link
Contributor

Thank you for this change, I actually needed it myself 👍

I took the liberty to fix the minor problem which made the tests fail.

@matejzero
Copy link
Contributor Author

Thanks for merging. I wanted to fix the failing tests, but was busy with gitlab migration for the last 2 weeks, so thanks for fixing that as well:)

@matejzero matejzero deleted the patch-1 branch May 20, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants