Skip to content

refactor: Migrate MultipartEncoder to RequestsBackend - #2421

Merged
nejch merged 2 commits into
python-gitlab:mainfrom
lmilbaum:MultipartEncoder
Dec 19, 2022
Merged

refactor: Migrate MultipartEncoder to RequestsBackend#2421
nejch merged 2 commits into
python-gitlab:mainfrom
lmilbaum:MultipartEncoder

Conversation

@lmilbaum

@lmilbaum lmilbaum commented Dec 11, 2022

Copy link
Copy Markdown

No description provided.

@codecov-commenter

codecov-commenter commented Dec 11, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2421 (48afd2c) into main (6682808) will decrease coverage by 0.00%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
- Coverage   96.16%   96.16%   -0.01%     
==========================================
  Files          85       85              
  Lines        5580     5579       -1     
==========================================
- Hits         5366     5365       -1     
  Misses        214      214
Flag Coverage Δ
api_func_v4 82.70% <88.23%> (-0.01%) ⬇️
cli_func_v4 82.95% <82.35%> (-0.01%) ⬇️
unit 87.54% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/http_backends/requests_backend.py 95.65% <87.50%> (-4.35%) ⬇️
gitlab/client.py 98.93% <100.00%> (+0.37%) ⬆️

@lmilbaum
lmilbaum force-pushed the MultipartEncoder branch 2 times, most recently from 12bc632 to 222c89a Compare December 19, 2022 10:26
@lmilbaum
lmilbaum marked this pull request as ready for review December 19, 2022 10:28
@lmilbaum

lmilbaum commented Dec 19, 2022

Copy link
Copy Markdown
Author

@nejch Could you please place a lated ok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@nejch

nejch commented Dec 19, 2022

Copy link
Copy Markdown
Member

@nejch Could you please place a lated ok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@lmilbaum you shoul have Triage rights now (check your email if not), so you should be able to do so yourself in the future.

@lmilbaum

lmilbaum commented Dec 19, 2022

Copy link
Copy Markdown
Author

@nejch Could you please place a lated ok-to-test on this PR? I want to verify the error is not caused by a flaky test.

@lmilbaum you shoul have Triage rights now (check your email if not), so you should be able to do so yourself in the future.

yay. Thank you for trusting me.

@lmilbaum lmilbaum self-assigned this Dec 19, 2022
@lmilbaum

lmilbaum commented Dec 19, 2022

Copy link
Copy Markdown
Author

@nejch Could you please place a lated ok-to-test on this PR? I want to verify the error is not caused by a flaky test.

yup. It was a flaky test.

nejch
nejch reviewed Dec 19, 2022
View reviewed changes
Comment thread gitlab/http_backends/requests_backend.py
@nejch
nejch merged commit 43b369f into python-gitlab:main Dec 19, 2022
@lmilbaum
lmilbaum deleted the MultipartEncoder branch December 19, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nejch nejch nejch approved these changes
@JohnVillalovos JohnVillalovos Awaiting requested review from JohnVillalovos

Assignees

@lmilbaum lmilbaum

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmilbaum @codecov-commenter @nejch