Skip to content

Conversation

@JohnVillalovos
Copy link
Member

No description provided.

 * Use `settings.delayed_group_deletion=False` as that is the
   recommended method to turn off the delayed group deletion now.
 * Change test to look for `default` as `pages` is not mentioned in
   the docs[1]

[1] https://docs.gitlab.com/ee/api/sidekiq_metrics.html#get-the-current-queue-metrics
@codecov-commenter
Copy link

Codecov Report

Merging #2280 (b87a2bc) into main (86b0e40) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   95.41%   95.28%   -0.14%     
==========================================
  Files          81       79       -2     
  Lines        5390     5238     -152     
==========================================
- Hits         5143     4991     -152     
  Misses        247      247              
Flag Coverage Δ
api_func_v4 82.55% <ø> (+1.25%) ⬆️
cli_func_v4 82.43% <ø> (-0.41%) ⬇️
unit 87.66% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/__init__.py
gitlab/cli.py

@nejch nejch merged commit fceeebc into main Sep 23, 2022
@nejch nejch deleted the jlvillal/docker_image branch September 23, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants