chore: change _repr_attr for Project to be path_with_namespace
#2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `_repr_attr` was `path` but that only gives the basename of the path. So https://gitlab.com/gitlab-org/gitlab would only show "gitlab". Using `path_with_namespace` it will now show "gitlab-org/gitlab"
Codecov Report
@@ Coverage Diff @@
## main #2203 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 81 81
Lines 5353 5353
=======================================
Hits 5110 5110
Misses 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
_repr_attrwaspathbut that only gives the basename ofthe path. So https://gitlab.com/gitlab-org/gitlab would only show
"gitlab". Using
path_with_namespaceit will now show"gitlab-org/gitlab"