Skip to content

Conversation

@nickbroon
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #2198 (8486b1b) into main (1cf5932) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
+ Coverage   95.53%   95.54%   +0.01%     
==========================================
  Files          81       81              
  Lines        5309     5322      +13     
==========================================
+ Hits         5072     5085      +13     
  Misses        237      237              
Flag Coverage Δ
api_func_v4 81.34% <100.00%> (-0.15%) ⬇️
cli_func_v4 82.95% <100.00%> (+0.13%) ⬆️
unit 87.26% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/releases.py 100.00% <100.00%> (ø)
gitlab/cli.py 100.00% <0.00%> (ø)
gitlab/v4/cli.py 90.78% <0.00%> (ø)

@nejch
Copy link
Member

nejch commented Jul 28, 2022

Thanks for the quick work @nickbroon just needs a commit message amend - I'll see if we can change the commit suggestion message on GitHub so we can avoid these issues.

@nickbroon
Copy link
Contributor Author

Or I could squash the commits if that's easier?

@nejch
Copy link
Member

nejch commented Jul 28, 2022

Or I could squash the commits if that's easier?

Perfect!

@nickbroon nickbroon force-pushed the nickbroon-release-sort-order branch from 8486b1b to b1dd284 Compare July 28, 2022 14:39
@nejch nejch enabled auto-merge July 28, 2022 14:45
@nejch nejch merged commit c33cb20 into python-gitlab:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants