fix: support array types for most resources #2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
force-pushed
the
fix/array-attributes
branch
from
44970c9 to
e740cfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
+ Coverage 95.53% 95.55% +0.01%
==========================================
Files 81 81
Lines 5309 5331 +22
==========================================
+ Hits 5072 5094 +22
Misses 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
requested changes
Jul 28, 2022
Member
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Wow! That looks like it took a lot of time to go through all the docs!! Thanks.
Left comments on two things I saw.
nejch
force-pushed
the
fix/array-attributes
branch
from
e740cfa to
6716897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #780.
I skipped
array of hashesand I didn't touch some endpoints like merge requests that I think need another look at this topic (merge requests in particular). It's already a chunky PR, so I split it into fix/test/docs commits.