Skip to content

Conversation

@JohnVillalovos
Copy link
Member

Ensure the path elements that are passed to the server are escaped.
For example a "/" will be changed to "%2F"

Closes: #2116

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #2117 (5d9c198) into main (ca3b438) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          78       78           
  Lines        5090     5095    +5     
=======================================
+ Hits         4853     4858    +5     
  Misses        237      237           
Flag Coverage Δ
cli_func_v4 82.43% <100.00%> (+0.01%) ⬆️
py_func_v4 81.11% <66.66%> (-0.03%) ⬇️
unit 87.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/base.py 100.00% <100.00%> (ø)

Ensure the path elements that are passed to the server are escaped.
For example a "/" will be changed to "%2F"

Closes: #2116
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/encodedid_path branch from 289fa25 to 5d9c198 Compare July 3, 2022 16:27
@JohnVillalovos JohnVillalovos requested a review from nejch July 3, 2022 16:39
@nejch
Copy link
Member

nejch commented Jul 3, 2022

Thanks for the quick fix @JohnVillalovos!

@nejch nejch merged commit 04c6063 into main Jul 3, 2022
@nejch nejch deleted the jlvillal/encodedid_path branch July 3, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get asset links issue if tag_name have "/" char

4 participants