chore: add the version of python-gitlab to GitlabError #2093
Conversation
|
Thanks @JohnVillalovos! This is a specific implementation for one exception. If we do this, a more generic approach might be useful I think, otherwise we might have to litter our code with custom exception messages. But I'm also not sure if exception messages are the right place for this. Did you get this idea from existing libraries? I think we should look into #2080, maybe in combination with exception hooks if we want this 🤔 not sure, it just seems more like a logging topic IMO? |
|
Good idea. Let me explore having it in the base GitlabExeception class. But probably not today... |
People will post tracebacks of exceptions but not post information on the version of python-gitlab used. Add the version of python-gitlab to the GitlabError exception message.
JohnVillalovos
force-pushed
the
jlvillal/version_in_keyerror
branch
from
f6028e6 to
7577c91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
=======================================
Coverage 94.72% 94.73%
=======================================
Files 78 78
Lines 5083 5088 +5
=======================================
+ Hits 4815 4820 +5
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JohnVillalovos
changed the title
I would also look at https://stackoverflow.com/questions/5191830/how-do-i-log-a-python-error-with-debug-information as a clean option. Of course, we'd need a nicer setup for #2080 first. |
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
People will post tracebacks of exceptions but not post information on
the version of python-gitlab used.
Add the version of python-gitlab to the GitlabError exception message.