chore: rename whaction and action to resource_action in CLI
#2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2054 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 78 78
Lines 4972 4972
=======================================
Hits 4700 4700
Misses 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Jun 5, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks @JohnVillalovos! looks good just a tiny comment about the help string.
nejch
reviewed
Jun 5, 2022
JohnVillalovos
force-pushed
the
jlvillal/resource
branch
from
7518605 to
d71c68c
Compare
Rename the variables `whaction` and `action` to `resource_action` to improve code-readability.
JohnVillalovos
force-pushed
the
jlvillal/resource
branch
from
d71c68c to
fb3f28a
Compare
nejch
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the variables
whactionandactiontoresource_actiontoimprove code-readability.