Skip to content

Some improvements to our tox environment defaults #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nejch merged 2 commits into from
May 10, 2022
Merged

Some improvements to our tox environment defaults #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b4f99
chore: rename the test which runs `flake8` to be `flake8`
JohnVillalovos May 10, 2022
55ace1d
chore: run the `pylint` check by default in tox
JohnVillalovos May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Run black code formatter (https://black.readthedocs.io/en/stable/)
run: tox -e black -- --check
- name: Run flake8 (https://flake8.pycqa.org/en/latest/)
run: tox -e pep8
run: tox -e flake8
- name: Run mypy static typing checker (http://mypy-lang.org/)
run: tox -e mypy
- name: Run isort import order checker (https://pycqa.github.io/isort/)
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
minversion = 1.6
skipsdist = True
skip_missing_interpreters = True
envlist = py310,py39,py38,py37,pep8,black,twine-check,mypy,isort,cz
envlist = py310,py39,py38,py37,flake8,black,twine-check,mypy,isort,cz,pylint

[testenv]
passenv = GITLAB_IMAGE GITLAB_TAG PY_COLORS NO_COLOR FORCE_COLOR
Expand Down Expand Up @@ -38,7 +38,7 @@ deps = -r{toxinidir}/requirements-lint.txt
commands =
mypy {posargs}

[testenv:pep8]
[testenv:flake8]
basepython = python3
envdir={toxworkdir}/lint
deps = -r{toxinidir}/requirements-lint.txt
Expand Down