Repository navigation
refactor(mixins): extract custom type transforms into utils - #2011
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
+ Coverage 92.67% 92.72% +0.04%
==========================================
Files 78 78
Lines 4958 4947 -11
==========================================
- Hits 4595 4587 -8
+ Misses 363 360 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
If you want to merge this as-is I am okay with that. We can always make it better in the future.
fa8fb57 to
bf0b688
Compare
|
@JohnVillalovos I've made some changes roughly as you suggested but I never got to refactoring the |
Sounds good. Approved. Not sure if you want to squash it into one commit or not. Or merge it as-is. |
bf0b688 to
ab2d572
Compare
Ah right makes sense, I've squashed it :) just didn't feel comfortable self-merging for this project. |
I'm trying to add support for multipart uploads to the generic package upload (see #2002), but unfortunately the logic for that is currently done directly in the
create()/update()methods (processing thedata/filesdict for theMultipartEncoder).This extracts that into a helper and handles
transform_filesso we can also use it forlist()which doesn't need it. This PR preps the code so the generic package one should be smaller.In the future I think we can simplify multipart encoding more and get rid of
filesaltogether, and just process everything indata- but wanted to keep this PR simple.