Skip to content

chore(ci): replace commitlint with commitizen #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JohnVillalovos merged 1 commit into from
May 1, 2022
Merged

chore(ci): replace commitlint with commitizen #1998

JohnVillalovos merged 1 commit into from
May 1, 2022

Conversation

@nejch
Copy link
Member

@nejch nejch commented Apr 30, 2022 •
edited
Loading

See #1996 (comment)

This also needs a small change in required checks temporarily

nejch
nejch commented Apr 30, 2022
View reviewed changes
requirements-lint.txt
@@ -1,5 +1,6 @@
argcomplete==2.0.0
argcomplete<=2.0.0
Copy link
Member Author

@nejch nejch Apr 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a PR in commitizen to bump to v2 so we can pin this again later.

@nejch nejch mentioned this pull request Apr 30, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #1998 (781be0d) into main (882fe7a) will increase coverage by 9.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
+ Coverage   83.47%   92.58%   +9.11%     
==========================================
  Files          78       78              
  Lines        4938     4938              
==========================================
+ Hits         4122     4572     +450     
+ Misses        816      366     -450
Flag Coverage Δ
cli_func_v4 81.49% <ø> (?)
py_func_v4 80.49% <ø> (?)
unit 83.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/base.py 92.59% <0.00%> (+0.52%) ⬆️
gitlab/exceptions.py 100.00% <0.00%> (+0.69%) ⬆️
gitlab/config.py 94.44% <0.00%> (+1.66%) ⬆️
gitlab/v4/objects/members.py 94.73% <0.00%> (+1.75%) ⬆️
gitlab/v4/objects/export_import.py 94.59% <0.00%> (+2.70%) ⬆️
gitlab/types.py 96.66% <0.00%> (+3.33%) ⬆️
gitlab/v4/objects/wikis.py 96.42% <0.00%> (+3.57%) ⬆️
gitlab/v4/objects/notes.py 94.23% <0.00%> (+3.84%) ⬆️
gitlab/v4/objects/groups.py 88.65% <0.00%> (+4.25%) ⬆️
gitlab/v4/objects/jobs.py 77.27% <0.00%> (+4.54%) ⬆️
... and 32 more

@nejch nejch marked this pull request as ready for review April 30, 2022 19:47
@nejch nejch force-pushed the chore/commitizen branch from 59a49d7 to 781be0d Compare April 30, 2022 19:55
@nejch nejch requested a review from JohnVillalovos May 1, 2022 08:23
JohnVillalovos
JohnVillalovos approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@JohnVillalovos JohnVillalovos merged commit b8d15fe into main May 1, 2022
@JohnVillalovos JohnVillalovos deleted the chore/commitizen branch May 1, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nejch @codecov-commenter @JohnVillalovos