Skip to content

feat(ux): display project.name_with_namespace on project repr #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nejch merged 1 commit into from
May 7, 2022
Merged

feat(ux): display project.name_with_namespace on project repr #1996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions gitlab/v4/objects/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,16 @@ class Project(RefreshMixin, SaveMixin, ObjectDeleteMixin, RepositoryMixin, RESTO
variables: ProjectVariableManager
wikis: ProjectWikiManager

def __repr__(self) -> str:
project_repr = super().__repr__()

if hasattr(self, "name_with_namespace"):
return (
f'{project_repr[:-1]} name_with_namespace:"{self.name_with_namespace}">'
Copy link
Member

@JohnVillalovos JohnVillalovos Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use the !r to quote the value.

Suggested change
f'{project_repr[:-1]} name_with_namespace:"{self.name_with_namespace}">'
f"{project_repr[:-1]} name_with_namespace:{self.name_with_namespace!r}>"

)
else:
return project_repr

@cli.register_custom_action("Project", ("forked_from_id",))
@exc.on_http_error(exc.GitlabCreateError)
def create_fork_relation(self, forked_from_id: int, **kwargs: Any) -> None:
Expand Down