Retry additional http transient errors #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sineaggi
force-pushed
the
retry-additional-http-transient-errors
branch
2 times, most recently
from
413dd16 to
3e6fef1
Compare
|
Running perfectly 👍 |
Sineaggi
force-pushed
the
retry-additional-http-transient-errors
branch
4 times, most recently
from
4928675 to
7f0d3d2
Compare
Author
|
@nejch Can you re-review? |
nejch
requested changes
Mar 26, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks again @Sineaggi, I was on holiday so there was a bit of delay there. I just made one last pass and just noticed some duplicate code. Could you clean that up?
We could probably also make the test code a bit shorter but that's for later perhaps. Thanks!
I'll make sure this makes it into the next release so I can also pause the scheduled release for the 28th until this is merged, if needed.
nejch
force-pushed
the
retry-additional-http-transient-errors
branch
from
7f0d3d2 to
5cbbf26
Compare
nejch
approved these changes
Apr 4, 2022
This was referenced Apr 4, 2022
gdubicki
added a commit
to gitlabform/gitlabform
that referenced
this pull request
Feb 18, 2023
Based on python-gitlab/python-gitlab#1904 (We really need to switch to python-gitlab under the hood...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #1648
This adds additional retries for the 52x caused by cloudflare.
This adds tests for the 52x range and the
requests.ConnectionErrorexception