Repository navigation
fix(services): use slug for id_attr instead of custom methods - #1870
Merged
Merged
Conversation
nejch
force-pushed
the
fix/project-services-id-attr
branch
from
February 2, 2022 01:09
904efae to
3d5357b
Compare
Member
|
We probably need some functional API tests for this. The services stuff is weird... But I would be okay with merging without it, but nicer with tests. |
Codecov Report
@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 92.35% 92.50% +0.14%
==========================================
Files 77 78 +1
Lines 4856 4871 +15
==========================================
+ Hits 4485 4506 +21
+ Misses 371 365 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
marked this pull request as ready for review
February 3, 2022 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191