Remove usage of httmock and clean up deprecations #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all usage of the `httpmock` library to using the `responses` library.
nejch
reviewed
Jan 16, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot for the rework @JohnVillalovos! A few minor things from me.
In the `responses` library the usage of `match_querystring` is deprecated. Convert to using `match`
JohnVillalovos
force-pushed
the
jlvillal/rm_httmock
branch
from
c5a4ab6 to
d16e41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.