test: use 'responses' in test_mixins_methods.py #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert from httmock to responses in test_mixins_methods.py This leaves only one file left to convert
nejch
reviewed
Jan 15, 2022
| assert isinstance(obj, FakeObject) | ||
| assert obj.foo == "bar" | ||
| assert obj.id == 42 | ||
| assert responses.assert_call_count(url, 1) is True |
Member
There was a problem hiding this comment.
As we aren't sharing any fixtures here, was the assert for 1 call intended for all methods or mostly for the one with 2 calls?
Maybe we could split test_list_mixin into test_list_mixin and test_list_mixin_as_generator then to really only test a single scenario per case, and use responses' own assert.
Member
There was a problem hiding this comment.
we can do that in a follow-up, we still have some httmock anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from httmock to responses in test_mixins_methods.py
This leaves only one file left to convert