Skip to content

Conversation

@nejch
Copy link
Member

@nejch nejch commented Dec 20, 2021

Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@nejch
Copy link
Member Author

nejch commented Dec 20, 2021

Looks like GH Actions is having a bad day again though 😅

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) December 20, 2021 23:43
@codecov-commenter
Copy link

Codecov Report

Merging #1768 (03bd85f) into main (ccefe80) will decrease coverage by 4.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
- Coverage   91.97%   87.47%   -4.50%     
==========================================
  Files          76       76              
  Lines        4759     4759              
==========================================
- Hits         4377     4163     -214     
- Misses        382      596     +214     
Flag Coverage Δ
cli_func_v4 81.34% <ø> (ø)
py_func_v4 ?
unit 83.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/files.py 62.66% <0.00%> (-30.67%) ⬇️
gitlab/v4/objects/milestones.py 70.96% <0.00%> (-29.04%) ⬇️
gitlab/utils.py 65.51% <0.00%> (-24.14%) ⬇️
gitlab/v4/objects/repositories.py 60.31% <0.00%> (-22.23%) ⬇️
gitlab/v4/objects/sidekiq.py 82.60% <0.00%> (-17.40%) ⬇️
gitlab/v4/objects/commits.py 80.00% <0.00%> (-14.67%) ⬇️
gitlab/v4/objects/snippets.py 83.67% <0.00%> (-14.29%) ⬇️
gitlab/v4/objects/clusters.py 81.81% <0.00%> (-12.13%) ⬇️
gitlab/v4/objects/templates.py 88.23% <0.00%> (-11.77%) ⬇️
gitlab/v4/objects/custom_attributes.py 89.28% <0.00%> (-10.72%) ⬇️
... and 22 more

@JohnVillalovos JohnVillalovos merged commit 1ac4329 into main Dec 20, 2021
@JohnVillalovos JohnVillalovos deleted the chore/renovate-pre-commit branch December 20, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants