Skip to content

Conversation

@JohnVillalovos
Copy link
Member

Fix pylint error "expression-not-assigned" and remove check from the
disabled list.

And I personally think it is much more readable now and is less lines
of code.

Fix pylint error "expression-not-assigned" and remove check from the
disabled list.

And I personally think it is much more readable now and is less lines
of code.
@codecov-commenter
Copy link

Codecov Report

Merging #1738 (a90eb23) into main (3a7d6f6) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   92.03%   91.95%   -0.08%     
==========================================
  Files          75       75              
  Lines        4681     4689       +8     
==========================================
+ Hits         4308     4312       +4     
- Misses        373      377       +4     
Flag Coverage Δ
cli_func_v4 81.40% <50.00%> (-0.06%) ⬇️
py_func_v4 80.93% <0.00%> (-0.14%) ⬇️
unit 83.15% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 81.38% <50.00%> (-0.95%) ⬇️

@nejch nejch merged commit 3679591 into main Dec 8, 2021
@nejch nejch deleted the jlvillal/pylint_fixes branch December 8, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants