Skip to content

Conversation

@JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos JohnVillalovos requested a review from nejch December 2, 2021 23:12
Enable the subset of the 'mypy --strict' options that work with no
changes to the code.
Enable 'warn_redundant_casts'for mypy and resolve one issue.
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_strict_two_steps branch from 80c89b8 to f40e9b3 Compare December 6, 2021 06:10
@codecov-commenter
Copy link

Codecov Report

Merging #1727 (f40e9b3) into main (ab841b8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1727   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          75       75           
  Lines        4683     4683           
=======================================
  Hits         4310     4310           
  Misses        373      373           
Flag Coverage Δ
cli_func_v4 81.42% <0.00%> (ø)
py_func_v4 81.03% <100.00%> (ø)
unit 83.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/keys.py 100.00% <100.00%> (ø)

@nejch nejch merged commit 1c33080 into main Dec 7, 2021
@nejch nejch deleted the jlvillal/mypy_strict_two_steps branch December 7, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants