chore: add get() methods for GetWithoutIdMixin based classes #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
from
2f550e2 to
d79ff6a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.02%
==========================================
Files 75 75
Lines 4689 4719 +30
==========================================
+ Hits 4312 4339 +27
- Misses 377 380 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
from
d79ff6a to
2e9cbda
Compare
JohnVillalovos
changed the title
JohnVillalovos
changed the title
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
from
2e9cbda to
ab82fd8
Compare
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
4 times, most recently
from
33b2d56 to
1453601
Compare
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
from
1453601 to
46f4d1a
Compare
nejch
reviewed
Dec 8, 2021
Add the get() methods for the GetWithoutIdMixin based classes. Update the tests/meta/test_ensure_type_hints.py tests to check to ensure that the get methods are defined with the correct return type.
JohnVillalovos
force-pushed
the
jlvillal/get_without_id
branch
from
46f4d1a to
d27c50a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the get() methods for the GetWithoutIdMixin based classes.
Update the tests/meta/test_ensure_type_hints.py tests to check to
ensure that the get methods are defined with the correct return type.