feat(api): add project milestone promotion #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds promotion to Project Milestones Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
Codecov Report
@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 91.95% 91.97% +0.02%
==========================================
Files 74 74
Lines 4323 4324 +1
==========================================
+ Hits 3975 3977 +2
+ Misses 348 347 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
approved these changes
Oct 31, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks @StingRayZA looks good, and the PromoteMixin does make sense now.
A group project fixture (instead of personal ones) might be useful in the future if we do more of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds promotion to Project Milestones
Fixes #1654