Skip to content

Also retry HTTP-based transient errors #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mitar wants to merge 1 commit into from
Closed

Also retry HTTP-based transient errors #1648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions gitlab/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,18 +609,29 @@ def http_request(
prepped.url, {}, streamed, verify, None
)

retry_transient_errors = kwargs.get(
"retry_transient_errors", self.retry_transient_errors
)
cur_retries = 0
while True:
result = self.session.send(prepped, timeout=timeout, **settings)
try:
result = self.session.send(prepped, timeout=timeout, **settings)
except requests.ConnectionError:
if retry_transient_errors and (
max_retries == -1 or cur_retries < max_retries
):
wait_time = 2 ** cur_retries * 0.1
cur_retries += 1
time.sleep(wait_time)
continue

raise

self._check_redirects(result)

if 200 <= result.status_code < 300:
return result

retry_transient_errors = kwargs.get(
"retry_transient_errors", self.retry_transient_errors
)
if (429 == result.status_code and obey_rate_limit) or (
result.status_code in [500, 502, 503, 504] and retry_transient_errors
):
Expand Down