Skip to content

fix(objects): rename confusing to_project_id argument #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnVillalovos merged 1 commit into from
Sep 11, 2021
Merged

fix(objects): rename confusing to_project_id argument #1599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gitlab/v4/objects/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ class Group(SaveMixin, ObjectDeleteMixin, RESTObject):
variables: GroupVariableManager
wikis: GroupWikiManager

@cli.register_custom_action("Group", ("to_project_id",))
@cli.register_custom_action("Group", ("project_id",))
@exc.on_http_error(exc.GitlabTransferProjectError)
def transfer_project(self, to_project_id, **kwargs):
def transfer_project(self, project_id, **kwargs):
"""Transfer a project to this group.

Args:
Expand All @@ -85,7 +85,7 @@ def transfer_project(self, to_project_id, **kwargs):
GitlabAuthenticationError: If authentication is not correct
GitlabTransferProjectError: If the project could not be transfered
"""
path = "/groups/%s/projects/%s" % (self.id, to_project_id)
path = "/groups/%s/projects/%s" % (self.id, project_id)
self.manager.gitlab.http_post(path, **kwargs)

@cli.register_custom_action("Group", ("scope", "search"))
Expand Down