Skip to content

refactor(objects): remove deprecated constants defined in objects #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnVillalovos merged 1 commit into from
Sep 11, 2021
Merged

refactor(objects): remove deprecated constants defined in objects #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions gitlab/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@
REPORTER_ACCESS: int = 20
DEVELOPER_ACCESS: int = 30
MAINTAINER_ACCESS: int = 40
MASTER_ACCESS: int = MAINTAINER_ACCESS
OWNER_ACCESS: int = 50

VISIBILITY_PRIVATE: int = 0
VISIBILITY_INTERNAL: int = 10
VISIBILITY_PUBLIC: int = 20
VISIBILITY_PRIVATE: str = "private"
VISIBILITY_INTERNAL: str = "internal"
VISIBILITY_PUBLIC: str = "public"

NOTIFICATION_LEVEL_DISABLED: str = "disabled"
NOTIFICATION_LEVEL_PARTICIPATING: str = "participating"
Expand Down
11 changes: 0 additions & 11 deletions gitlab/v4/objects/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,4 @@
from .variables import *
from .wikis import *

# TODO: deprecate these in favor of gitlab.const.*
VISIBILITY_PRIVATE = "private"
VISIBILITY_INTERNAL = "internal"
VISIBILITY_PUBLIC = "public"

ACCESS_GUEST = 10
ACCESS_REPORTER = 20
ACCESS_DEVELOPER = 30
ACCESS_MASTER = 40
ACCESS_OWNER = 50

__all__ = [name for name in dir() if not name.startswith("_")]
2 changes: 1 addition & 1 deletion tests/functional/api/test_snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def test_project_snippets(project):
"title": "snip1",
"file_name": "foo.py",
"content": "initial content",
"visibility": gitlab.v4.objects.VISIBILITY_PRIVATE,
"visibility": gitlab.VISIBILITY_PRIVATE,
}
)

Expand Down