fix(api): replace deprecated name_regex attribute in delete_in_bulk()
#1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
+ Coverage 91.18% 91.59% +0.40%
==========================================
Files 74 74
Lines 4188 4272 +84
==========================================
+ Hits 3819 3913 +94
+ Misses 369 359 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Jun 30, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot @antti-mikael! Just a small note on keeping the arguments in sync with the API.
antti-mikael
force-pushed
the
fix/registry-deleteinbulk-deprecated-attr
branch
from
8b5d647 to
db6eed0
Compare
antti-mikael
force-pushed
the
fix/registry-deleteinbulk-deprecated-attr
branch
2 times, most recently
from
1dcc077 to
6c419ee
Compare
The `name_regex` attribute has been deprecated in favor of `name_regex_delete`. See: https://gitlab.com/gitlab-org/gitlab/-/commit/ce99813cf54
antti-mikael
force-pushed
the
fix/registry-deleteinbulk-deprecated-attr
branch
from
6c419ee to
1099e96
Compare
This was referenced Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
name_regexattribute has been deprecated in favor ofname_regex_delete.See: https://gitlab.com/gitlab-org/gitlab/-/commit/ce99813cf54