chore: move 'gitlab/tests/' dir to 'tests/unit/' #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the 'gitlab/tests/' directory to 'tests/unit/' so we have all the tests located under the 'tests/' directory.
nejch
approved these changes
May 29, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Nice, thanks. Things are starting to look cleaner :)
Heads-up for distro package maintainers this will need a change if you're testing the package outside of tox. I recommend only running tests/unit if you want to avoid the docker dependency.
@kloczek @derekschrock @svenstaro @williamh @FedericoCeratto
| recursive-include tests * | ||
| recursive-include docs *j2 *.py *.rst api/*.rst Makefile make.bat | ||
| recursive-include gitlab/tests/data * | ||
| recursive-include tests/unit/data * |
Member
There was a problem hiding this comment.
I'm thinking we can actually remove this now as we already recurse tests/ in line 3. But this file needs a cleanup, I'll push a small PR after :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the 'gitlab/tests/' directory to 'tests/unit/' so we have all the
tests located under the 'tests/' directory.