Skip to content

Conversation

@max-wittig
Copy link
Member

@nejch I think it's time again to release. It's been a while

@JohnVillalovos
Copy link
Member

Cool! I like a new release 😊

@nejch
Copy link
Member

nejch commented Apr 25, 2021

Yay, agreed! 😸

I'd just like to fix one small thing before this goes out, when I added #1363 the deprecationwarning was too eager and on master now everyone gets it when Gitlab is instantiated:

>>> gl = Gitlab.from_config()
/home/nejc/repos/python-gitlab/gitlab/v4/objects/audit_events.py:70: DeprecationWarning: This class has been renamed to ProjectAuditEvent and will be removed in a future release.
  class ProjectAudit(ProjectAuditEvent):
/home/nejc/repos/python-gitlab/gitlab/v4/objects/audit_events.py:74: DeprecationWarning: This class has been renamed to ProjectAuditEventManager and will be removed in a future release.
  class ProjectAuditManager(ProjectAuditEventManager):

@max-wittig could you merge #1414 and then this is ready? :)

@max-wittig
Copy link
Member Author

Thinking about it, this version should anyway be called 3.0.0, as we introduced some breaking changes with the way kwargs are used.

@nejch
Copy link
Member

nejch commented Apr 25, 2021

Thinking about it, this version should anyway be called 3.0.0, as we introduced some breaking changes with the way kwargs are used.

Oh, you mean #1278? That's not merged yet 😊

I was hoping to finish #1296 for 3.0.0 as that would be a very popular feature IMO but might also have some breaking behavior.

@max-wittig
Copy link
Member Author

Makes sense. I merged it. Let's go for 2.7.0 then 👍

@nejch nejch merged commit e37de18 into master Apr 25, 2021
@nejch nejch deleted the chore/bump-to-2-7-0 branch April 25, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants