chore: add _create_attrs & _update_attrs to RESTManager #1371
Conversation
Add the attributes: _create_attrs and _update_attrs to the RESTManager class. This is so that we stop using getattr() if we don't need to. This also helps with type-hints being available for these attributes.
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Hey @JohnVillalovos sorry for the delay, thanks a lot!
I really liked the namedtuple approach in your earlier PR #1366, is the idea to introduce it back in a follow-up so this can be a smaller change for now?
It would take out some of the mystery in all those attributes for new contributors I think.
No worries! Thanks for reviewing 😀
You read my mind! I thought let's get the small change in first and wait on the giant change.
Agreed. It took me awhile to figure out what they were for. I think with the NamedTuple it should be clearer. Thanks again. |
|
@nejch Once this is merged I will work on the follow-up patch to use namedtuple. |
2 participants
Add the attributes: _create_attrs and _update_attrs to the RESTManager
class. This is so that we stop using getattr() if we don't need to.
This also helps with type-hints being available for these attributes.