Skip to content

Conversation

@nejch
Copy link
Member

@nejch nejch commented Mar 7, 2021

This adds group audit events, moves all audit events into one module and makes the class naming consistent.

Closes #1107, closes #948.

@nejch nejch force-pushed the feat/all-audit-events branch from 6101513 to 23e37c5 Compare March 7, 2021 12:12
@codecov-io
Copy link

Codecov Report

Merging #1363 (23e37c5) into master (48fc907) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   79.92%   80.01%   +0.08%     
==========================================
  Files          73       73              
  Lines        4010     4028      +18     
==========================================
+ Hits         3205     3223      +18     
  Misses        805      805              
Flag Coverage Δ
unit 80.01% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/events.py 100.00% <ø> (ø)
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/audit_events.py 100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py 76.40% <100.00%> (+0.26%) ⬆️
gitlab/v4/objects/projects.py 73.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fc907...23e37c5. Read the comment docs.

@nejch nejch force-pushed the feat/all-audit-events branch from 23e37c5 to 2a0fbdf Compare March 7, 2021 14:00
@max-wittig
Copy link
Member

@nejch Sorry for ignoring that for soo long. Looks good!

@max-wittig max-wittig merged commit 02ce49e into master Mar 24, 2021
@max-wittig max-wittig deleted the feat/all-audit-events branch March 24, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for group audit events Add support for audit events

4 participants