Skip to content

chore: add and fix some type-hints in gitlab/client.py #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nejch merged 1 commit into from
Feb 28, 2021
Merged

chore: add and fix some type-hints in gitlab/client.py #1343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions gitlab/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ def http_list(
query_data: Optional[Dict[str, Any]] = None,
as_list=None,
**kwargs,
):
) -> Union["GitlabList", List[Dict[str, Any]]]:
"""Make a GET request to the Gitlab server for list-oriented queries.

Args:
Expand Down Expand Up @@ -772,7 +772,9 @@ def http_delete(self, path: str, **kwargs) -> requests.Response:
return self.http_request("delete", path, **kwargs)

@gitlab.exceptions.on_http_error(gitlab.exceptions.GitlabSearchError)
def search(self, scope: str, search: str, **kwargs) -> requests.Response:
def search(
self, scope: str, search: str, **kwargs
) -> Union["GitlabList", List[Dict[str, Any]]]:
"""Search GitLab resources matching the provided string.'

Args:
Expand Down Expand Up @@ -896,10 +898,10 @@ def __len__(self) -> int:
return 0
return int(self._total)

def __next__(self):
def __next__(self) -> Dict[str, Any]:
return self.next()

def next(self) -> "Gitlab":
def next(self) -> Dict[str, Any]:
try:
item = self._data[self._current]
self._current += 1
Expand Down