Skip to content

Conversation

@JohnVillalovos
Copy link
Member

Discovered this when I ran flake8 on the file. Unfortunately I was the
one who introduced this wrong variable name :(

Discovered this when I ran flake8 on the file. Unfortunately I was the
one who introduced this wrong variable name :(
@codecov-io
Copy link

Codecov Report

Merging #1332 (c2857aa) into master (0b67ca2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1332   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          72       72           
  Lines        3746     3746           
=======================================
  Hits         3008     3008           
  Misses        738      738           
Flag Coverage Δ
unit 80.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/cli.py 53.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b67ca2...15ec41c. Read the comment docs.

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha well if someone tried to use the v3 API at this point they wouldn't get very far anyway :) Thanks!

@nejch nejch merged commit 665c0c3 into python-gitlab:master Feb 25, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/fix_variable branch February 25, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants