Skip to content

fix: undefined name errors #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nejch merged 1 commit into from
Feb 23, 2021
Merged

fix: undefined name errors #1322

nejch merged 1 commit into from
Feb 23, 2021

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Feb 23, 2021

Discovered that there were some undefined names.

@JohnVillalovos
fix: undefined name errors
48ec9e0 
Discovered that there were some undefined names.
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #1322 (48ec9e0) into master (d90be1e) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files          71       71           
  Lines        3738     3738           
=======================================
  Hits         3000     3000           
  Misses        738      738
Flag Coverage Δ
unit 80.25% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/ldap.py 54.54% <0.00%> (ø)
gitlab/v4/objects/projects.py 69.20% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90be1e...48ec9e0. Read the comment docs.

nejch
nejch approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks, really need more test coverage for this.

Some of this must have just worked before some of the refactoring because of those blanket imports. Or no one ever noticed 🤔

@nejch nejch merged commit a7ec67f into python-gitlab:master Feb 23, 2021
@JohnVillalovos
Copy link
Member Author

JohnVillalovos commented Feb 24, 2021

Wow thanks, really need more test coverage for this.

Some of this must have just worked before some of the refactoring because of those blanket imports. Or no one ever noticed 🤔

I ran flake8 locally after doing the patch to remove the 'import *' lines. And found these missing names.

@JohnVillalovos JohnVillalovos deleted the jlvillal/missing_vars branch February 24, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nejch nejch nejch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnVillalovos @codecov-io @nejch