feat(api,cli): make user agent configurable #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
force-pushed
the
feat/override-user-agent
branch
from
bf2d944 to
a69a214
Compare
Member
Author
|
Should the "Require pull request reviews before merging" maybe also be added to required checks in branch protection? So I don't accidentally merge my own stuff 😆 |
max-wittig
reviewed
Feb 1, 2021
max-wittig
approved these changes
Feb 1, 2021
Member
|
Btw. there should be no 3.5 users, as pypi will just give you the old version, if you download with pip. |
Member
Author
Oh cool, I didn't even realize that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking that some tools/libraries using python-gitlab (or people triggering the CLI in pipelines) might want to define their own user agent.