Skip to content

chore(env): add pre-commit and commit-msg hooks #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-wittig merged 1 commit into from
Aug 30, 2020
Merged

chore(env): add pre-commit and commit-msg hooks #1162

max-wittig merged 1 commit into from
Aug 30, 2020

Conversation

@nejch
Copy link
Member

@nejch nejch commented Aug 30, 2020

Closes #1128. I was having this issue too sometimes when switching workstations and forgot to format :P

I went with commitlint to be consistent with CI but maybe commitizen makes sense in the future to keep dev dependencies Python-only.

@nejch nejch requested a review from max-wittig August 30, 2020 12:31
@max-wittig
Copy link
Member

max-wittig commented Aug 30, 2020

Looks good. Yes commitizen might make sense in the future!

@max-wittig max-wittig merged commit 97d8261 into master Aug 30, 2020
@nejch nejch deleted the chore/pre-commit-config branch May 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create pre-commit hook for commit message linting

3 participants

@nejch @max-wittig