Skip to content

Pass kwargs to subsequent queries in GitlabList (fixes: #1123) #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-wittig merged 3 commits into from
Jun 30, 2020
Merged

Pass kwargs to subsequent queries in GitlabList (fixes: #1123) #1124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d011ac
fix: pass kwargs to subsequent queries in gitlab list
tyates-indeed Jun 22, 2020
72ffa01
fix: make query kwargs consistent between call in init and next
tyates-indeed Jun 22, 2020
a349b90
fix: do not check if kwargs is none
tyates-indeed Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gitlab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,11 @@ class GitlabList(object):

def __init__(self, gl, url, query_data, get_next=True, **kwargs):
self._gl = gl
self._query(url, query_data, **kwargs)

# Preserve kwargs for subsequent queries
self._kwargs = kwargs.copy()

self._query(url, query_data, **self._kwargs)
self._get_next = get_next

def _query(self, url, query_data=None, **kwargs):
Expand Down Expand Up @@ -864,7 +868,7 @@ def next(self):
pass

if self._next_url and self._get_next is True:
self._query(self._next_url)
self._query(self._next_url, **self._kwargs)
return self.next()

raise StopIteration