Skip to content

Fix/keyset pagination revert #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bufferoverflow merged 2 commits into from
Jun 9, 2020
Merged

Fix/keyset pagination revert #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71fe16
fix: disable default keyset pagination
max-wittig Jun 9, 2020
870e7ea
chore: bump version to 2.3.1
max-wittig Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions gitlab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from gitlab import utils # noqa

__title__ = "python-gitlab"
__version__ = "2.3.0"
__version__ = "2.3.1"
__author__ = "Gauvain Pocentek"
__email__ = "gauvainpocentek@gmail.com"
__license__ = "LGPL3"
Expand Down Expand Up @@ -643,17 +643,7 @@ def http_list(self, path, query_data=None, as_list=None, **kwargs):
get_all = kwargs.pop("all", False)
url = self._build_url(path)

order_by = kwargs.get("order_by")
pagination = kwargs.get("pagination")
page = kwargs.get("page")
if (
path in ALLOWED_KEYSET_ENDPOINTS
and (not order_by or order_by == "id")
and (not pagination or pagination == "keyset")
and not page
):
kwargs["pagination"] = "keyset"
kwargs["order_by"] = "id"

if get_all is True and as_list is True:
return list(GitlabList(self, url, query_data, **kwargs))
Expand Down
1 change: 1 addition & 0 deletions tools/python_test_v4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,7 @@

assert len(gl.projects.list(owned=True)) == 2
assert len(gl.projects.list(search="admin")) == 1
assert len(gl.projects.list(as_list=False)) == 4

# test pagination
l1 = gl.projects.list(per_page=1, page=1)
Expand Down