Skip to content

Update auth docs #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-wittig merged 1 commit into from
Jan 26, 2020
Merged

Update auth docs #1000

max-wittig merged 1 commit into from
Jan 26, 2020

Conversation

@matusf
Copy link
Contributor

@matusf matusf commented Jan 25, 2020

Hi, I removed the docs regarding email/password auth since it's no longer supported by python-gitlab.

@max-wittig
Copy link
Member

max-wittig commented Jan 26, 2020

Thanks for your MR. That's helpful. Just a small comment

max-wittig
max-wittig reviewed Jan 26, 2020
View reviewed changes
.gitignore Outdated
venv/
.mypy_cache
.vscode

Copy link
Member

@max-wittig max-wittig Jan 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are local files, which should be managed by a global gitconfig instead.

Copy link
Contributor Author

@matusf matusf Jan 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@max-wittig max-wittig merged commit 7843ace into python-gitlab:master Jan 26, 2020
@max-wittig
Copy link
Member

max-wittig commented Jan 26, 2020

Thanks for the MR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-wittig max-wittig max-wittig left review comments

Assignees

@matusf matusf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matusf @max-wittig