You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @thuhc. Thanks for your issue report! This library is currently only maintained by me and I don't really focus on EE features. But if you want to fix this here, I would be happy to review your PR
@JohnVillalovos that is not the same API. What is being asked for is the approvals API which shows stats on the current state of approvals for the MR. What you linked are the settings that determine what kind of approvals are required.
@JohnVillalovos that is not the same API. What is being asked for is the approvals API which shows stats on the current state of approvals for the MR. What you linked are the settings that determine what kind of approvals are required.
The issue description above said they wanted support for doing: project.approvals.get() and as far as I can tell PG supports that.
If there is something else that is missing then an issue should be opened for that.
There's also an example for approval state in the docs linked, you can scroll down to mr.approval_state.get(). I admit I also personally don't have access to enterprise features though and so it's usually not a priority, not sure about @JohnVillalovos.
So I'm unsure how well this works against a real server (not mocked unit tests), here we really rely on the community when implementing features :)
There's also an example for approval state in the docs linked, you can scroll down to mr.approval_state.get(). I admit I also personally don't have access to enterprise features though and so it's usually not a priority, not sure about @JohnVillalovos.
So I'm unsure how well this works against a real server (not mocked unit tests), here we really rely on the community when implementing features :)
Wow. I looked at this page like 5 times and didn't see that. That is what I'd been looking for!
@JaxonWright ah, feel free to split up that page a bit if you think it's not that clear, and open a PR here, we'll be more than happy to take a look! :)
Activity
samvasko commentedon Sep 9, 2019
The workaround right now is to call the attributes method. eg:
mr.approvals.get().attributesmax-wittig commentedon Sep 9, 2019
Hi @thuhc. Thanks for your issue report! This library is currently only maintained by me and I don't really focus on EE features. But if you want to fix this here, I would be happy to review your PR
tymonx commentedon Nov 12, 2019
I have added two missing attributes: #934. It will not solve the missing
approvalslist but it fixes approvals configuration during the.save()JohnVillalovos commentedon Jan 1, 2022
Closing this since as far as I know we have support for the Merge Request Approvals API:
https://python-gitlab.readthedocs.io/en/main/gl_objects/merge_request_approvals.html
JaxonWright commentedon Jul 1, 2022
@JohnVillalovos that is not the same API. What is being asked for is the approvals API which shows stats on the current state of approvals for the MR. What you linked are the settings that determine what kind of approvals are required.
EDIT: upon further analysis, I was wrong
JohnVillalovos commentedon Jul 1, 2022
The issue description above said they wanted support for doing:
project.approvals.get()and as far as I can tell PG supports that.If there is something else that is missing then an issue should be opened for that.
nejch commentedon Jul 1, 2022
There's also an example for approval state in the docs linked, you can scroll down to
mr.approval_state.get(). I admit I also personally don't have access to enterprise features though and so it's usually not a priority, not sure about @JohnVillalovos.So I'm unsure how well this works against a real server (not mocked unit tests), here we really rely on the community when implementing features :)
JaxonWright commentedon Jul 1, 2022
Wow. I looked at this page like 5 times and didn't see that. That is what I'd been looking for!
nejch commentedon Jul 1, 2022
@JaxonWright ah, feel free to split up that page a bit if you think it's not that clear, and open a PR here, we'll be more than happy to take a look! :)