CLI event list fails on None #717

Activity

1. xarx00 commented on Feb 27, 2019

   

   xarx00

   on Feb 27, 2019

   Last edited by xarx00

   ContributorAuthor

   More actions

   The subsequent error mentioned above is

     File "c:\program files\python27\lib\site-packages\gitlab\v4\cli.py", line 364, in display
       value = value.replace('\r', '').replace('\n', ' ')
   AttributeError: 'NoneType' object has no attribute 'replace'
   

   It is caused by that some events on my gilab server do not have "target_title" filled in. Actually, the do not have filled in any relevant attribute, for some reason.

   Fix

   Fix of the subsequent (NOT the original error):

   --- cli.py.orig	2019-02-24 17:37:53.000000000 +0100
   +++ cli.py	2019-02-27 19:17:56.045767100 +0100
   @@ -357,7 +358,7 @@
                    id = getattr(obj, obj._id_attr)
                    print('%s: %s' % (obj._id_attr.replace('_', '-'), id))
                if hasattr(obj, '_short_print_attr'):
   -                value = getattr(obj, obj._short_print_attr)
   +                value = getattr(obj, obj._short_print_attr) or 'None'
                    value = value.replace('\r', '').replace('\n', ' ')
                    # If the attribute is a note (ProjectCommitComment) then we do
                    # some modifications to fit everything on one line
   
2. xarx00 commented on Feb 27, 2019

   

   xarx00

   on Feb 27, 2019

   ContributorAuthor

   More actions

   Fix

   In order to fix the primary error of this issue, I had to rename the "action" attribute:
   fix.diff.zip
3. xarx00

   changed the title [-]gitlab event list fails on None[/-] [+]CLI event list fails on None[/+] on Mar 1, 2019
4. gpocentek commented on Mar 3, 2019

   

   gpocentek

   on Mar 3, 2019

   Contributor

   More actions

   Hi @xarx00

   Could you create a pull request with this change? Thanks.
5. xarx00

   added a commit that references this issue on Mar 4, 2019

   Fix for python-gitlab#717: Rename of conflicting 'action' attribute; …

   ...

   eee4cce
6. max-wittig

   added a commit that references this issue on Jul 21, 2019

   fix(cli): don't fail when the short print attr value is None

   ...

   This issue will close once commit 8d1552a is merged into the 'main' branch.

   8d1552a
7. max-wittig

   closed this as completedin #835on Jul 21, 2019
8. github-actions

   locked as resolved and limited conversation to collaborators on Nov 8, 2021